Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions for cross compilation #27

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

erikbosch
Copy link
Contributor

Also removing unused file

Fixes #26

doc/docker.md Outdated
You might need to install `qemu-user-static` depending on your distribution.

```console
docker build -f Dockerfile --progress=plain --build-arg --platform=linux/arm64 -t can-provider:latest .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not so sure if, this does "all the necessary things", I would prefer we just give the buildx version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand from https://www.docker.com/blog/faster-multi-platform-builds-dockerfile-cross-compilation-guide/ and docker/cli#3314 the two commands are today equal.

So then it becomes more a question of which syntax we want to promote :-)

I tested building with both, I however only verified that it reported the right architecture.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is equivalent, what is --build-arg doing? In any case "buildx" might then be more compatible, and also working on docker(-cli?) < 23.00.

Copy link
Contributor Author

@erikbosch erikbosch Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a typo (good find), but I can remove the first alternative

@SebastianSchildt SebastianSchildt merged commit 9dc39dc into eclipse-kuksa:main Jul 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build instructions outdated
2 participants